Fix percentile to include players who lost the puzzle#28
Merged
kishanasokan merged 6 commits intomainfrom Feb 25, 2026
Merged
Conversation
- Fix empty blue bar on large screens by using --full-vh viewport compensation - Make Radiordle logo/title clickable to navigate home from archive - Remove max-height cap on post-puzzle modal for desktop screens - Add archive stats disclaimer under Statistics heading in results modal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…de-to-close - Replace opaque black backdrop with semi-transparent bg-black/50 on all modals - Lock background scroll when any modal is open (body overflow: hidden) - Add click-outside-to-close to Legal modals (Privacy Policy, Terms of Service) - Remove desktop max-height cap on Stats modal to match Results modal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The backdrop class change from bg-black to bg-black/50 broke E2E tests that located modals via .fixed.inset-0.bg-black CSS selector. Replaced with stable data-testid="results-modal" attribute. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The "How You Compare" percentile was only counting winners who took more guesses, ignoring players who failed the puzzle entirely. This caused misleadingly low rankings (e.g. "Top 43%" for a 1-guess win on a puzzle with 60% win rate). Now fetches total attempts from game_stats_by_puzzle and counts losers as "worse than user" in the percentile calculation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The annotated image overlay added a second img[alt*="Puzzle"] element, causing Playwright strict mode violations across all E2E shards. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tstanmay13
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
times_playedfromgame_stats_by_puzzleview and counts losers as "worse than user" in the percentile mathWhat changed
getPuzzleGuessDistribution()now also queriesgame_stats_by_puzzlefor total attempts (including losses)calculatePuzzlePercentile()accepts optionaltotalAttemptsparam and includes losers in the calculationWhat is NOT affected
calculatePercentileBeat)submitGameResult()and all game submission logicTest plan
🤖 Generated with Claude Code